fix(commonjs): register dynamic modules when a different loader (i.e typescript) loads the entry file#599
Conversation
|
@lukastaegert Do you see any possible issues with this? |
lukastaegert
left a comment
lukastaegert
left a comment
There was a problem hiding this comment.
I am a little behind looking through these PRs so please be patient. So you claim that this fixes a bug. Unfortunately I am completely missing a test that was broken without this change and is fixed with this change. This would serve both as documentation and as a guarantee that future refactorings do not break this again. Could you add one?
danielgindi
force-pushed
the
feature/ts_compat
branch
from
f0532c8 to
6dd7ea1
Compare
Done. Now there's a good test for this :-) |
danielgindi
force-pushed
the
feature/ts_compat
branch
from
6dd7ea1 to
45cfb23
Compare
|
I've rebased on master. Snapshots. Every time... |
|
@LarsDenBakker Are we merging this? It's currently a blocker for TypeScript projects! |
|
@danielgindi standard ops here is to wait for 2 approvals. please lend that green check mark if you think it's good to go and we'll merge it post haste |
Yeah I know :-) I intentionally tagged @LarsDenBakker. As whatever blocker it is, it's always a good idea to have another set of eyes before publishing to production... |
|
Fine for me! |
Yeah I think @shellscape really wants the green checkmark 🤣 |
|
:) it's useful for tracking history |
|
@shellscape I think that this fix deserves a release, as TS users currently can't fully benefit from commonjs plugin. I bumped into this and using a branch, but everybody else dont :) |
|
@danielgindi we merged this less than 24 hours ago. patience please! 🙏 |
Apologizes, I didn't mean to dictate the exact timeline 😂 |
4 participants
Rollup Plugin Name:
commonjsThis PR contains:
Are tests included?
Breaking Changes?
Description
I've encountered in a TypeScript project a weird phenomenon, where the entry file does not go through
loadin thecommonjsplugin.As a result, the of prepending the main entry with the registration calls of the dynamic modules - does not take place.
This means that modules were trying to call dynamic modules, but they were not in the runtime commonjs registry, and so they failed.
I fixed this by moving this phase to the
transformrather thanload.A small fix that had to go hand in hand, is making sure that these
commonjsRegistercalls are always first as some modules may be appended to thesourcesarray before them.All tests pass, and this works now in typescript project.