fix(commonjs): fixed access to dynamic node_modules module with subfolder (i.e 'logform/json')#601
Merged
shellscape merged 1 commit intorollup:masterfrom Oct 11, 2020
Conversation
shellscape
approved these changes
Oct 9, 2020
danielgindi
changed the title
danielgindi
force-pushed
the
bugfix/misinterpreted_slash
branch
2 times, most recently
from
fe6e9e9 to
4a5cf9b
Compare
Contributor
Author
|
I've improved that regex even more, to be somewhat readable |
Contributor
Author
|
@shellscape I don't mean to be pushy but... ;-) |
…lder (i.e 'logform/json')
danielgindi
force-pushed
the
bugfix/misinterpreted_slash
branch
from
4a5cf9b to
8937563
Compare
danielgindi
changed the title
Collaborator
|
@danielgindi Ideally we'd like to get at least one more pair of eyes on this before merge. Could you request a review from a few other folks? |
Contributor
Author
Of course :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
commonjsThis PR contains:
Are tests included?
Breaking Changes?
Description
In cases where there's access to a dynamically loaded module, with a slash in the middle (i.e.
require('logform/json')), the result was empty.This is due to a regex that matched cases it shouldn't have.