fix(typescript): add composite to validation checks#618
Merged
NotWoods merged 5 commits intorollup:masterfrom Oct 23, 2020
Merged
fix(typescript): add composite to validation checks#618NotWoods merged 5 commits intorollup:masterfrom
NotWoods merged 5 commits intorollup:masterfrom
Conversation
TypeScript's `composite` compiler option produces declaration files, too. Add it to the relevant validation check.
Was not there before, too, seems to need more setup
NotWoods
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
typescriptThis PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers: -
Description
TypeScript's
compositecompiler option produces declaration files, too. I stumbled upon this and did get a generic validation error right at the end when the plugin wants to print the files to the outdir but cannot find one. To fix it, I added an additional check to the relevant validation.