docs(typescript): More informative error messages#619
Merged
NotWoods merged 1 commit intorollup:masterfrom Oct 24, 2020
Merged
Conversation
Adding if it's either a Rollup or TS option
NotWoods
approved these changes
Oct 24, 2020
pnevares
approved these changes
Oct 24, 2020
Contributor
pnevares
left a comment
pnevares
left a comment
There was a problem hiding this comment.
I love improving the project's DX like this, thanks for thinking about it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
typescriptThis PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers: -
Description
As a Rollup novice I had some problems figuring out what some of the error messages meant. More specifically, I did not know what options they talked about, so I added more context, telling if it's either a Rollup or TS compiler option.