This repository was archived by the owner on Aug 4, 2021. It is now read-only.
fixed bug with resolve and absolute aliases on windows#18
Closed
hzrd149 wants to merge 3 commits intorollup:masterfrom
hzrd149:master
Closed
fixed bug with resolve and absolute aliases on windows#18hzrd149 wants to merge 3 commits intorollup:masterfrom hzrd149:master
hzrd149 wants to merge 3 commits intorollup:masterfrom
hzrd149:master
Conversation
Contributor
|
Thanks for the PR. I'm hoping that this is similar to #22. If you get a chance to try 1.4.0 could you see if the issue is resolved please? |
Author
|
@Rich-Harris looks like that fixed it 👍 thanks for the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pull request is to fix the bug that arises when you use absolute paths in aliases on Windows
for example, if you do this
and then if you import
lib/some/fileit wont resolve to/absolute/path/project/lib/some/file.jsx, since thelibalias has the drive letter in it, and the code here dose not test for a drive lettersto fix this, i made it strip out the drive letter once it has replaced the alias in the
importeeIdpath