This repository was archived by the owner on Aug 4, 2021. It is now read-only.
fix-bug: Could not load G:\luobata\canvas-input-methods\src\ui/index (imported.....#30
Closed
Luobata wants to merge 1 commit intorollup:masterfrom
Closed
fix-bug: Could not load G:\luobata\canvas-input-methods\src\ui/index (imported.....#30Luobata wants to merge 1 commit intorollup:masterfrom
Luobata wants to merge 1 commit intorollup:masterfrom
Conversation
…e match by the regex; Signed-off-by: Luobata <602975805@qq.com>
Contributor
|
@Luobata |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find it will throw out an exception when I import a module with alias like 'import init from 'UI/index.js' in window. It's same as the issue #11 .
And I find it it's the bug with the updatedId in windows in started with 'G:' so it can't be match by the regex /^.?//, so I change the regex and format the updatedId(.split(path.sep).join('/')) to promise it would be matched by the regex.
I also find it that the dist file in the node_modules in version 1.3.1, it has posix.resolve, and path.resolve in source code.And I had tested that it work with path.resolve after my PR.
Signed-off-by: Luobata 602975805@qq.com