This repository was archived by the owner on Aug 4, 2021. It is now read-only.
Fix pkg.browser mappings issue by specifying a value of false#183
Merged
lukastaegert merged 2 commits intorollup:masterfrom Feb 22, 2019
Merged
Fix pkg.browser mappings issue by specifying a value of false#183lukastaegert merged 2 commits intorollup:masterfrom
false#183lukastaegert merged 2 commits intorollup:masterfrom
Conversation
allex
changed the title
false issue.false
TrySound
reviewed
Oct 18, 2018
allex
added a commit
to allex/rollup-plugin-node-resolve
that referenced
this pull request
Oct 18, 2018
allex
added a commit
to allex/rollup-plugin-node-resolve
that referenced
this pull request
Oct 19, 2018
Contributor
|
@guybedford @TrySound @lukastaegert @keithamus anything I can do to help with this PR? I'm trying to migrate some projects to rollup and being able to ignore node built-ins that I know for sure won't be called in the browser (ala webpack) would be really nice. In the meantime, I'm rolling my own shims with rollup-plugin-shim, but it's frustrating because I have to shim each export which I think this PR obviates. Let me know if there's a better workaround! |
Member
|
Will try to have a look tomorrow |
Contributor
|
@lukastaegert yay! I'm here all day (PST), let me know if I can help! |
allex
added a commit
to allex/rollup-plugin-node-resolve
that referenced
this pull request
Feb 20, 2019
lukastaegert
suggested changes
Feb 20, 2019
Member
lukastaegert
left a comment
lukastaegert
left a comment
There was a problem hiding this comment.
Looks good apart from the two remaining suggestions
lukastaegert
approved these changes
Feb 22, 2019
Member
|
Released |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix pkg.browser with some maps specifying a value of
falseto ignore a module. (https://github.com/defunctzombie/package-browser-field-spec)