Skip to content
This repository was archived by the owner on Aug 4, 2021. It is now read-only.

Add support for es2015 field#186

Closed
gregmagolan wants to merge 1 commit intorollup:masterfrom
gregmagolan:es2015-support
Closed

Add support for es2015 field#186
gregmagolan wants to merge 1 commit intorollup:masterfrom
gregmagolan:es2015-support

Conversation

@gregmagolan
Copy link
Copy Markdown

The es2015 package.json field is part of both angular and rxjs npm packages. Default is set to false so as not to change the current behavior.

For reference, https://www.npmjs.com/package/rollup-plugin-node-resolve-angular and https://www.npmjs.com/package/rollup-plugin-node-resolve-next both handle the es2015 field.

@gregmagolan gregmagolan changed the title Add support or es2015 field Add support for es2015 field Nov 30, 2018
@gregmagolan
Copy link
Copy Markdown
Author

This change would be helpful downstream in bazel-contrib/rules_nodejs#429 and angular/angular#27220.

@TrySound
Copy link
Copy Markdown
Member

Better to achieve this via #182

@gregmagolan
Copy link
Copy Markdown
Author

Closing in favour of #182

@gregmagolan gregmagolan closed this Dec 5, 2018
@gregmagolan
Copy link
Copy Markdown
Author

@TrySound Can we land this in the meantime since #182 is stalled? This is a small change relative to #182.

@gregmagolan gregmagolan reopened this Jan 4, 2019
@TrySound
Copy link
Copy Markdown
Member

TrySound commented Jan 4, 2019

It's not stalled. Maintainers don't have free time to finish it. And we wouldn't like to add a feature which will be removed later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants