Open
Conversation
volhalink
commented
Jul 15, 2018
volhalink
commented
- HT4.1 Реализовать форму для добавления коммента (опция: с валидациями) в CommentList
- HT4.2 Написать мидлвар для генерации случайных id
- HT4.3 Переписать articles на ключ->значение
- HT4.4 Добавлять комментарий к статье
romabelka
reviewed
Jul 16, 2018
| const { text } = this.state | ||
| const error = this.validate(userName, text) | ||
| if (error) { | ||
| showError(error) |
Owner
There was a problem hiding this comment.
Не очень понял идею хранить значение формы тут, а ошибку в сторе
| success(state.articles[articleId], comment) | ||
| } | ||
|
|
||
| export default (store) => (next) => (action) => { |
Owner
There was a problem hiding this comment.
Как-то тут слишком много всего. Через мидлвары будет проходить каждый экшин, они должны быть максимально общими, завязывать на конкретные экшины - не лучшее решение
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.