Open
Conversation
Owner
|
если хочешь - да, но зачем? |
romabelka
reviewed
Jul 23, 2018
| export default connect( | ||
| null, | ||
| { | ||
| fetchData: (id) => { |
Author
There was a problem hiding this comment.
Я думала так нужно сделать, чтобы всегда передавался articleID
| }) | ||
| case LOAD_COMMENTS + START: | ||
| console.log('loading comments') | ||
| return state.set('loading', true).set('loaded', false) |
Owner
There was a problem hiding this comment.
здесь не достаточно повесить loading на весь comments, ведь ты для конкрентной статьи загружаешь
Author
There was a problem hiding this comment.
Флаг в comments уже не используется, удалю. Я использую флаги commentsLoading / commentsLoaded, которые устанавливаю в reducer/articles при обработке LOAD_COMMENTS_START / LOAD_COMMENTS_SUCCESS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Добрый день
Сейчас у нас хранятся все загруженные комментарии на все приложение(используется mergeIn). Как сделать, чтобы состояние списка комментариев было уникальным для каждой статьи? В ArticleRecord делать Immutable List с комментариями? Но тогда получается громоздкая структура.