Skip to content

Conversation

@gantoine
Copy link
Member

@gantoine gantoine commented Nov 17, 2025

Description
Explain the changes or enhancements you are proposing with this pull request.

Inspired by @death-droid work on #2660

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces an automated mechanism to maintain the accuracy of the HowLongToBeat (HLTB) API URL. By programmatically discovering the API endpoint directly from the HLTB website, the system can adapt to potential changes in the API's structure, ensuring continued functionality without requiring manual intervention. This enhancement improves the robustness and maintainability of the integration with the HLTB service.

Highlights

  • HLTB API URL Discovery: Introduced a new Python script (backend/utils/update_hltb_api_url.py) that dynamically discovers the latest HowLongToBeat (HLTB) API search URL by parsing the HLTB website's Next.js application script.
  • Dynamic Endpoint Extraction: The script fetches the HLTB homepage, identifies the Next.js _app JavaScript chunk, downloads it, and uses regular expressions to extract the current API endpoint and associated tokens.
  • API URL Persistence: The dynamically discovered HLTB API URL is then written to a fixture file (backend/handler/metadata/fixtures/hltb_api_url) for use by other parts of the application.
  • File Renaming and Import Update: The file backend/utils/json.py was renamed to backend/utils/json_module.py, and its import statement in backend/handler/socket_handler.py was updated accordingly.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/update-hltb-api-url.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a Python script to dynamically discover and update the HowLongToBeat (HLTB) API URL, which is a solid approach to handle their rotating endpoints. It also includes a file rename to prevent conflicts with standard Python libraries. My review focuses on improving the new script's robustness, maintainability, and adherence to best practices. I've provided suggestions to use more specific exception handling, move hardcoded values to constants, and improve error reporting. Additionally, I've highlighted the fragile nature of the regular expression used for API discovery, as this poses a significant risk to the script's long-term stability.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025

Test Results

640 tests  ±0   639 ✅ ±0   1m 14s ⏱️ +3s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 2be1bab. ± Comparison against base commit 3d6ba6c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11352 7468 66% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
backend/handler/socket_handler.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 2be1bab by action🐍

@gantoine gantoine merged commit 11867f1 into master Nov 18, 2025
8 checks passed
@gantoine gantoine deleted the hltb-github-action branch November 18, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants