-
-
Notifications
You must be signed in to change notification settings - Fork 320
Fix multipart strings #2688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multipart strings #2688
Conversation
Summary of ChangesHello @gantoine, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors how multi-part strings are handled in the frontend, particularly for messages involving counts of ROMs being added, removed, or deleted. Instead of concatenating several translation keys and dynamic values, the UI now uses single, parameterized translation keys. This streamlines the code in Vue components and centralizes the string construction within the localization files, making the application's internationalization more robust and easier to manage across various languages. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a great improvement for internationalization. It refactors multipart strings in Vue components to use single translation keys with interpolation and pluralization, which simplifies the templates and makes localization easier. The corresponding locale files have been updated accordingly. Additionally, many new translation keys have been added and the locale files have been sorted alphabetically, which improves maintainability.
Description
Explain the changes or enhancements you are proposing with this pull request.
Checklist
Please check all that apply.