-
-
Notifications
You must be signed in to change notification settings - Fork 320
Update docker compose variables #2849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @SaraVieira, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses and resolves PostgreSQL connection failures experienced when initially running the 'docker compose' setup. It achieves this by standardizing the default PostgreSQL credentials within the 'docker-compose.yml' file, ensuring that the 'postgres' service and the 'authentik' application services are configured with compatible default usernames and passwords, thereby enabling out-of-the-box functionality. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request improves the consistency of environment variables in docker-compose.yml for the PostgreSQL setup, which resolves a connection issue for the Authentik services when using a .env file. However, I've identified a critical issue where the PostgreSQL container will fail to start for new users who copy the env.template file, due to an empty password being set. This needs to be addressed to ensure the setup works out-of-the-box.
| POSTGRES_PASSWORD: ${POSTGRES_PASSWORD:-authentik} | ||
| POSTGRES_USER: ${POSTGRES_USER:-romm} | ||
| POSTGRES_DB: ${POSTGRES_DB:-authentik} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While these changes correctly align the environment variables for the PostgreSQL service and its consumers, there's a critical issue regarding the password handling that could prevent the service from starting for new users.
The env.template file specifies POSTGRES_PASSWORD=. When a user copies this to a .env file, the POSTGRES_PASSWORD variable is set to an empty string. Docker Compose's variable substitution will then use this empty string for ${POSTGRES_PASSWORD:-authentik}, instead of the default value authentik.
The official PostgreSQL Docker image requires a non-empty password and will fail to initialize if POSTGRES_PASSWORD is empty. This will cause the romm-postgres-dev container to fail on startup.
To ensure an out-of-the-box working experience, this needs to be addressed. A simple fix would be to provide a default password in env.template, for example: POSTGRES_PASSWORD=authentik. Since that file is not part of this PR, another solution should be considered to make the setup more resilient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
Description
This makes some changes to the docker compose that allows the PostgreSQL connection to work out of the box if you have any credentials
When downloading and simply running
docker composeI was getting a bunch of connection failed inromm-authentik-workerand this fixed itChecklist
Please check all that apply.
Screenshots (if applicable)