[ROMM-2877] Drop index on rom file content

[gantoine]

Description
^{Explain the changes or enhancements you are proposing with this pull request.}

Adding an index for content seems unnecessary, and will fail in postgres with large files/content body.

Fixes #2877

Checklist
^{Please check all that apply.}

• I've tested the changes locally
• I've updated relevant comments
• I've assigned reviewers for this PR
• I've added unit tests that cover the changes

[gemini-code-assist]

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request removes an unnecessary and potentially problematic database index on the content column of the rom_notes table. The index was found to cause issues, particularly with large data entries in PostgreSQL, and its removal improves database stability and compatibility without impacting core functionality. The associated database-specific logic for index handling has also been cleaned up.

Highlights

• Index Removal: The idx_rom_notes_content index on the rom_notes table has been removed from the database migration script.
• PostgreSQL Compatibility: This change addresses potential failures in PostgreSQL when dealing with large content fields, as the index was problematic and could cause issues.
• Code Cleanup: Database-specific utility imports (is_mariadb, is_mysql) and associated conditional logic for index creation and dropping have been removed, simplifying the migration script.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes the database index on the content column of the rom_notes table within an Alembic migration. This is a good change, as indexing large text columns can lead to performance problems and even errors during migration, especially with large data. The changes are correctly implemented in both the upgrade and downgrade functions of the migration. Additionally, related unused code, such as database-specific checks and imports, has been removed, and the database connection is now initialized closer to its point of use, which improves code clarity. The changes are clean, targeted, and well-justified.

[github-actions]

Test Results

702 tests  ±0   701 ✅ ±0   1m 26s ⏱️ ±0s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit e2df40d. ± Comparison against base commit 9fe49ba.

[github-actions]

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
12120	7879	65%	0%	🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: e2df40d by action🐍