Open
Conversation
Author
|
Just a heads up, I don't really know how GitHub Pages works, so I may have broken it with my changes accidentally |
Owner
i am mostly new to it also, i'm not sure how to do a code merge in github, that's why i have not done so yet. |
Author
|
@ronmurphy by code merge do you mean pull request? or something else? |
Owner
|
yes, the pull request! LOL, sorry, oldschool dev here and i am trying to get up to speed on this new stuff. |
Author
|
@ronmurphy oh i see lol, they are pretty easy to use tbh, you just press merge and it puts my code on your main branch when we are ready. once you learn it, its super easy to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have organised the html, css and js code into separate files for readability and organisational purposes, as well as moving the icon related files into their own folder. This means that the paths have changed, and the python files must be ran from the project root.
The reorganising removes the ability to open the html file directly in the browser, as we run into CORS issues. The solution is to host it using a webserver, like the vs code extension in the readme.
Another solution is to integrate a simple flask webserver to serve the html file properly, which is up to you whether you think this is necessary.
I have also fixed a font issue, where some of the page text was defaulting to the standard html font. I added Google Font's Poppins to the head tag and included it in the css to solve this issue.
When i first ran the project, the webpage would not load, as the js script was looking for an element with id
startTour, which had been commented out. I temporarily resolved this by commenting out the js code that causes this.These are all my proposed changes, i would like to know what you think!