Skip to content

Project Organisation + Bug Fixes#1

Open
Orbitix wants to merge 4 commits intoronmurphy:mainfrom
Orbitix:main
Open

Project Organisation + Bug Fixes#1
Orbitix wants to merge 4 commits intoronmurphy:mainfrom
Orbitix:main

Conversation

@Orbitix
Copy link
Copy Markdown

@Orbitix Orbitix commented Dec 3, 2024

I have organised the html, css and js code into separate files for readability and organisational purposes, as well as moving the icon related files into their own folder. This means that the paths have changed, and the python files must be ran from the project root.

The reorganising removes the ability to open the html file directly in the browser, as we run into CORS issues. The solution is to host it using a webserver, like the vs code extension in the readme.

Another solution is to integrate a simple flask webserver to serve the html file properly, which is up to you whether you think this is necessary.

I have also fixed a font issue, where some of the page text was defaulting to the standard html font. I added Google Font's Poppins to the head tag and included it in the css to solve this issue.

When i first ran the project, the webpage would not load, as the js script was looking for an element with id startTour, which had been commented out. I temporarily resolved this by commenting out the js code that causes this.

These are all my proposed changes, i would like to know what you think!

@Orbitix
Copy link
Copy Markdown
Author

Orbitix commented Dec 3, 2024

Just a heads up, I don't really know how GitHub Pages works, so I may have broken it with my changes accidentally

@ronmurphy
Copy link
Copy Markdown
Owner

Just a heads up, I don't really know how GitHub Pages works, so I may have broken it with my changes accidentally

i am mostly new to it also, i'm not sure how to do a code merge in github, that's why i have not done so yet.

@Orbitix
Copy link
Copy Markdown
Author

Orbitix commented Dec 18, 2024

@ronmurphy by code merge do you mean pull request? or something else?

@ronmurphy
Copy link
Copy Markdown
Owner

yes, the pull request! LOL, sorry, oldschool dev here and i am trying to get up to speed on this new stuff.

@Orbitix
Copy link
Copy Markdown
Author

Orbitix commented Dec 19, 2024

@ronmurphy oh i see lol, they are pretty easy to use tbh, you just press merge and it puts my code on your main branch when we are ready.

once you learn it, its super easy to use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants