refactor(context): rewrite context code generator from Perl to Go#661
Merged
Conversation
Replace gen.pl with gen.go using text/template for idiomatic Go code generation. Move hand-written GetAuthenticatorSafe() from generated context.go to admin.go. Add TestGenContextUpToDate to catch gen.go / context.go drift in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace the Perl code generator (
gen.pl) with an idiomatic Go equivalent (gen.go) usingtext/template.Why
Removes the Perl dependency from the project toolchain. The Go version is testable —
TestGenContextUpToDateverifies the generated output stays in sync withcontext.goduringmake test.Changes
gen.pl, addgen.gowith//go:build ignoreGetAuthenticatorSafe()from generatedcontext.goto hand-writtenadmin.goTestGenContextUpToDate— runsgo run gen.goand diffs againstcontext.goTesting
make lint✅,make client server✅,make vuln✅TestGenContextUpToDatepasses (0.05s)