ci(docker): chain build into deploy workflow#662
Merged
Conversation
Extract Docker build+push into a reusable workflow and call it from both docker-build-pr and docker-deploy-pr. The deploy workflow now checks if the image exists on Docker Hub before building, so a single "docker deploy" comment handles everything. - Add docker-build-reusable.yaml with workflow_call trigger - Refactor docker-build-pr to call the reusable workflow - Refactor docker-deploy-pr: check image, build if needed, deploy - Use exact match (trim) instead of contains for comment triggers - Guard deploy and notify jobs against permission failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
docker deploynow automatically builds the image if it doesn't exist on Docker Hub, removing the need to commentdocker buildfirst.Why
Previously deploying a PR required two comments (
docker build→ wait →docker deploy). Now one comment does both.Changes
docker-build-reusable.yaml— reusable workflow with build+push logicdocker-build-pr.yaml— calls reusable, exact match trigger, permission-aware notifydocker-deploy-pr.yaml— checks image viadocker manifest inspect, conditionally builds, then deploystrim() ==) instead ofcontains()for comment triggersTesting
docker deployon a PR with/without existing image