feat(i18n): add Japanese language support with translations and flag#752
Open
jp-yendo wants to merge 1 commit into
Open
feat(i18n): add Japanese language support with translations and flag#752jp-yendo wants to merge 1 commit into
jp-yendo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What
Adds Japanese (日本語,
ja) as a new built-in language for the Plik webapp.Why
Expanding language coverage. Japanese is widely used in Asia (~125M speakers) and there is active demand from Japanese users in our environment.
Changes
webapp/src/locales/ja.json— Full Japanese translation (all keys fromen.json)webapp/public/flags/ja.svg— Flag of Japan (日の丸)webapp/src/settings.js— addedjaentry toBUILTIN_LANGUAGES(alphabetical order, betweenitandnl)webapp/src/i18n.js— addedjaimport and registration inmessages"ja": "日本語"added to thelanguagePickersectionTranslation choices
"{n} day | {n} days"collapses to"{n} 日"Notes
{value},{count},{n}, etc.) are preserved verbatim in all strings.Testing
Verified manually in the browser with both Japanese and English locales: