Fix jupyroot on Windows by bellenot · Pull Request #9107 · root-project/root

bellenot · 2021-10-12T14:50:38Z

No description provided.

phsft-bot · 2021-10-12T14:50:44Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-10-12T16:26:31Z

Build failed on mac11.0/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2021-10-13T09:01:07Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

lgtm-com · 2021-10-13T09:32:48Z

This pull request fixes 1 alert when merging 02a9a3a into 4449ef4 - view on LGTM.com

fixed alerts:

1 for Unused import

etejedor · 2021-10-13T09:59:04Z

bindings/jupyroot/python/JupyROOT/helpers/utils.py


    def _getPngImage(self):
-        ofile = tempfile.NamedTemporaryFile(suffix=".png")
+        ofile = tempfile.NamedTemporaryFile(suffix=".png", delete=False)


Why do we need to prevent deletion via the destruction of the NamedTemporaryFile object and delete the underlying file explicitly later?

To prevent the following error:

Error in callback <bound method CaptureDrawnPrimitives._post_execute of <JupyROOT.helpers.utils.CaptureDrawnPrimitives object at 0x0C321C58>> (for post_execute): --------------------------------------------------------------------------- PermissionError Traceback (most recent call last) ~\build\release\bin\JupyROOT\helpers\utils.py in _post_execute(self) 461 462 def _post_execute(self): --> 463 NotebookDraw() 464 465 def register(self): ~\build\release\bin\JupyROOT\helpers\utils.py in NotebookDraw() 450 def NotebookDraw(): 451 DrawGeometry() --> 452 DrawCanvases() 453 DrawRCanvases() 454 ~\build\release\bin\JupyROOT\helpers\utils.py in DrawCanvases() 441 drawers = GetCanvasDrawers() 442 for drawer in drawers: --> 443 drawer.Draw() 444 445 def DrawRCanvases(): ~\build\release\bin\JupyROOT\helpers\utils.py in Draw(self) 598 599 def Draw(self): --> 600 self._display() 601 return 0 602 ~\build\release\bin\JupyROOT\helpers\utils.py in _display(self) 583 self._jsDisplay() 584 else: --> 585 self._pngDisplay() 586 587 def GetDrawableObjects(self): ~\build\release\bin\JupyROOT\helpers\utils.py in _pngDisplay(self) 572 573 def _pngDisplay(self): --> 574 img = self._getPngImage() 575 IPython.display.display(img) 576 ~\build\release\bin\JupyROOT\helpers\utils.py in _getPngImage(self) 566 with _setIgnoreLevel(ROOT.kError): 567 self.drawableObject.SaveAs(ofile.name) --> 568 img = IPython.display.Image(filename=ofile.name, format='png', embed=True) 569 #ofile.close() 570 #os.unlink(ofile.name) c:\python38-32\lib\site-packages\IPython\core\display.py in __init__(self, data, url, filename, format, embed, width, height, retina, unconfined, metadata) 1229 self.retina = retina 1230 self.unconfined = unconfined -> 1231 super(Image, self).__init__(data=data, url=url, filename=filename, 1232 metadata=metadata) 1233 c:\python38-32\lib\site-packages\IPython\core\display.py in __init__(self, data, url, filename, metadata) 635 self.metadata = {} 636 --> 637 self.reload() 638 self._check_data() 639 c:\python38-32\lib\site-packages\IPython\core\display.py in reload(self) 1261 """Reload the raw data from file or URL.""" 1262 if self.embed: -> 1263 super(Image,self).reload() 1264 if self.retina: 1265 self._retina_shape() c:\python38-32\lib\site-packages\IPython\core\display.py in reload(self) 660 """Reload the raw data from file or URL.""" 661 if self.filename is not None: --> 662 with open(self.filename, self._read_flags) as f: 663 self.data = f.read() 664 elif self.url is not None: PermissionError: [Errno 13] Permission denied: 'C:\\Users\\sftnight\\AppData\\Local\\Temp\\tmpk49jx00w.png'

See the documentation of NamedTemporaryFile in tempfile:

Whether the name can be used to open the file a second time, while the named temporary file is still open, varies across platforms (it can be so used on Unix; it cannot on Windows NT or later).

Ok I see thanks!

etejedor · 2021-10-13T10:00:28Z

bindings/jupyroot/python/JupyROOT/helpers/utils.py

   return True

-_enableJSVis = False
+if 'win32' in sys.platform:


This change is done by this commit and undone by the next one. Is this intended? Then I propose the change is just removed from both commits.

Yes, it is intended.

etejedor · 2021-10-13T10:03:30Z

bindings/jupyroot/python/JupyROOT/helpers/utils.py

 import select
 import tempfile
-import pty
+if not 'win32' in sys.platform:


I just checked an pty is actually not used anywhere in this file anymore, so just a stale import. You can perhaps remove it altogether.

Fine with me

etejedor · 2021-10-13T10:05:13Z

bindings/jupyroot/python/JupyROOT/helpers/utils.py

    for extName in extNames:
        extMgr.load_extension(extName)
-    captures.append(StreamCapture())
+    if not 'win32' in sys.platform:


So atm no text output is seen in the notebook if it comes from C++ code on Windows, is this right?

etejedor · 2021-10-13T10:08:06Z

bindings/jupyroot/python/JupyROOT/__init__.py

 if _is_ipython:
-    from IPython import get_ipython
-    cppcompleter.load_ipython_extension(get_ipython())
+    if not 'win32' in sys.platform:


The only effect of this is that we won't have tab completion for now, correct?

phsft-bot · 2021-10-13T10:49:30Z

Build failed on mac11.0/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

- Remove unused `import pty` - Disable stream capture (currently not working on Windows). The output coming from C++ (ROOT) will only print in the command prompt and not in the notebook (to be investigated) - Disable tab completion (currently not working on Windows). - Add the `delete=False` argument in `NamedTemporaryFile()` and manually delete the created file to prevent the following error: ``` Error in callback <bound method CaptureDrawnPrimitives._post_execute of <JupyROOT.helpers.utils.CaptureDrawnPrimitives object at 0x0C321C58>> (for post_execute): --------------------------------------------------------------------------- PermissionError Traceback (most recent call last) ~\build\release\bin\JupyROOT\helpers\utils.py in _post_execute(self) 461 462 def _post_execute(self): --> 463 NotebookDraw() 464 465 def register(self): ~\build\release\bin\JupyROOT\helpers\utils.py in NotebookDraw() 450 def NotebookDraw(): 451 DrawGeometry() --> 452 DrawCanvases() 453 DrawRCanvases() 454 ~\build\release\bin\JupyROOT\helpers\utils.py in DrawCanvases() 441 drawers = GetCanvasDrawers() 442 for drawer in drawers: --> 443 drawer.Draw() 444 445 def DrawRCanvases(): ~\build\release\bin\JupyROOT\helpers\utils.py in Draw(self) 598 599 def Draw(self): --> 600 self._display() 601 return 0 602 ~\build\release\bin\JupyROOT\helpers\utils.py in _display(self) 583 self._jsDisplay() 584 else: --> 585 self._pngDisplay() 586 587 def GetDrawableObjects(self): ~\build\release\bin\JupyROOT\helpers\utils.py in _pngDisplay(self) 572 573 def _pngDisplay(self): --> 574 img = self._getPngImage() 575 IPython.display.display(img) 576 ~\build\release\bin\JupyROOT\helpers\utils.py in _getPngImage(self) 566 with _setIgnoreLevel(ROOT.kError): 567 self.drawableObject.SaveAs(ofile.name) --> 568 img = IPython.display.Image(filename=ofile.name, format='png', embed=True) 569 #ofile.close() 570 #os.unlink(ofile.name) c:\python38-32\lib\site-packages\IPython\core\display.py in __init__(self, data, url, filename, format, embed, width, height, retina, unconfined, metadata) 1229 self.retina = retina 1230 self.unconfined = unconfined -> 1231 super(Image, self).__init__(data=data, url=url, filename=filename, 1232 metadata=metadata) 1233 c:\python38-32\lib\site-packages\IPython\core\display.py in __init__(self, data, url, filename, metadata) 635 self.metadata = {} 636 --> 637 self.reload() 638 self._check_data() 639 c:\python38-32\lib\site-packages\IPython\core\display.py in reload(self) 1261 """Reload the raw data from file or URL.""" 1262 if self.embed: -> 1263 super(Image,self).reload() 1264 if self.retina: 1265 self._retina_shape() c:\python38-32\lib\site-packages\IPython\core\display.py in reload(self) 660 """Reload the raw data from file or URL.""" 661 if self.filename is not None: --> 662 with open(self.filename, self._read_flags) as f: 663 self.data = f.read() 664 elif self.url is not None: PermissionError: [Errno 13] Permission denied: 'C:\\Users\\sftnight\\AppData\\Local\\Temp\\tmpk49jx00w.png' ``` For the details, see the documentation of `NamedTemporaryFile` in [tempfile](https://docs.python.org/3/library/tempfile.html): ``` Whether the name can be used to open the file a second time, while the named temporary file is still open, varies across platforms (it can be so used on Unix; it cannot on Windows NT or later). ```

bellenot · 2021-10-13T11:43:44Z

Superseded by #9109

- Remove unused `import pty` - Disable stream capture (currently not working on Windows). The output coming from C++ (ROOT) will only print in the command prompt and not in the notebook (to be investigated) - Disable tab completion (currently not working on Windows). - Add the `delete=False` argument in `NamedTemporaryFile()` and manually delete the created file to prevent the following error: ``` Error in callback <bound method CaptureDrawnPrimitives._post_execute of <JupyROOT.helpers.utils.CaptureDrawnPrimitives object at 0x0C321C58>> (for post_execute): --------------------------------------------------------------------------- PermissionError Traceback (most recent call last) ~\build\release\bin\JupyROOT\helpers\utils.py in _post_execute(self) 461 462 def _post_execute(self): --> 463 NotebookDraw() 464 465 def register(self): ~\build\release\bin\JupyROOT\helpers\utils.py in NotebookDraw() 450 def NotebookDraw(): 451 DrawGeometry() --> 452 DrawCanvases() 453 DrawRCanvases() 454 ~\build\release\bin\JupyROOT\helpers\utils.py in DrawCanvases() 441 drawers = GetCanvasDrawers() 442 for drawer in drawers: --> 443 drawer.Draw() 444 445 def DrawRCanvases(): ~\build\release\bin\JupyROOT\helpers\utils.py in Draw(self) 598 599 def Draw(self): --> 600 self._display() 601 return 0 602 ~\build\release\bin\JupyROOT\helpers\utils.py in _display(self) 583 self._jsDisplay() 584 else: --> 585 self._pngDisplay() 586 587 def GetDrawableObjects(self): ~\build\release\bin\JupyROOT\helpers\utils.py in _pngDisplay(self) 572 573 def _pngDisplay(self): --> 574 img = self._getPngImage() 575 IPython.display.display(img) 576 ~\build\release\bin\JupyROOT\helpers\utils.py in _getPngImage(self) 566 with _setIgnoreLevel(ROOT.kError): 567 self.drawableObject.SaveAs(ofile.name) --> 568 img = IPython.display.Image(filename=ofile.name, format='png', embed=True) 569 #ofile.close() 570 #os.unlink(ofile.name) c:\python38-32\lib\site-packages\IPython\core\display.py in __init__(self, data, url, filename, format, embed, width, height, retina, unconfined, metadata) 1229 self.retina = retina 1230 self.unconfined = unconfined -> 1231 super(Image, self).__init__(data=data, url=url, filename=filename, 1232 metadata=metadata) 1233 c:\python38-32\lib\site-packages\IPython\core\display.py in __init__(self, data, url, filename, metadata) 635 self.metadata = {} 636 --> 637 self.reload() 638 self._check_data() 639 c:\python38-32\lib\site-packages\IPython\core\display.py in reload(self) 1261 """Reload the raw data from file or URL.""" 1262 if self.embed: -> 1263 super(Image,self).reload() 1264 if self.retina: 1265 self._retina_shape() c:\python38-32\lib\site-packages\IPython\core\display.py in reload(self) 660 """Reload the raw data from file or URL.""" 661 if self.filename is not None: --> 662 with open(self.filename, self._read_flags) as f: 663 self.data = f.read() 664 elif self.url is not None: PermissionError: [Errno 13] Permission denied: 'C:\\Users\\sftnight\\AppData\\Local\\Temp\\tmpk49jx00w.png' ``` For the details, see the documentation of `NamedTemporaryFile` in [tempfile](https://docs.python.org/3/library/tempfile.html): ``` Whether the name can be used to open the file a second time, while the named temporary file is still open, varies across platforms (it can be so used on Unix; it cannot on Windows NT or later). ```

Fix jupyroot on Windows

8cf3a0c

bellenot requested a review from etejedor October 12, 2021 14:50

bellenot self-assigned this Oct 12, 2021

Fix "access denied" error with png images on Windows

02a9a3a

etejedor reviewed Oct 13, 2021

View reviewed changes

bellenot closed this Oct 13, 2021

bellenot deleted the fix-jupyroot-windows branch February 7, 2022 14:26

Conversation

bellenot commented Oct 12, 2021

Uh oh!

phsft-bot commented Oct 12, 2021

Uh oh!

phsft-bot commented Oct 12, 2021

Failing tests:

Uh oh!

phsft-bot commented Oct 13, 2021

Uh oh!

lgtm-com bot commented Oct 13, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bellenot Oct 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

phsft-bot commented Oct 13, 2021

Failing tests:

Uh oh!

bellenot commented Oct 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bellenot Oct 13, 2021 •

edited

Loading