-
Notifications
You must be signed in to change notification settings - Fork 4
backend to create all the respective objects and relations on order start #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
9f6403f
feat(db): added params column to taskPlans table
gregorykan 9d86557
feat(tasks): reverted to older task plan creation code
gregorykan a87e9ed
feat(orders): added new migration to create orders table
gregorykan ff63e4e
feat(orders): moved stuff into dux folder
gregorykan ac28582
start working on task worker page
ahdinosaur 6c65156
better profile component!
ahdinosaur 6d51eab
working dashboard tasks and start to task worker
ahdinosaur e11f8c7
feat(orders): added new service and hook for order creation
gregorykan 446e971
feat(orders): create new hook to create prereq task plan. added new m…
gregorykan a91620f
feat(tasks): refactor getter to reference assigneeId
gregorykan 0000d33
feat(orders): finished create parent task plan hook
gregorykan 79cdf1c
feat(package.json): added script to delete and reinitliaize and seed db
gregorykan a929f61
feat(tasks): added hook to create child task plans after creation of …
gregorykan b42734c
feat(tasks): resolve Promise.all at the right level
gregorykan 96f9f36
fix(tasks): made getter defensive
gregorykan 4f4ef07
chore(refactor): ensure array return for childTaskRecipes
gregorykan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| import { createStructuredSelector } from 'reselect' | ||
|
|
||
| import getTaskPlans from '../../tasks/getters/getTaskPlans' | ||
| import getParentTaskPlans from '../../tasks/getters/getParentTaskPlans' | ||
|
|
||
| const getDashboardProps = createStructuredSelector({ | ||
| taskPlans: getTaskPlans | ||
| taskPlans: getParentTaskPlans | ||
| }) | ||
|
|
||
| export default getDashboardProps |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| exports.up = function (knex, Promise) { | ||
| return knex.schema.table('taskPlans', function (table) { | ||
| table.json('params').references('taskPlans.id') | ||
| }) | ||
| } | ||
|
|
||
| exports.down = function (knex, Promise) { | ||
| return knex.schema.table('taskPlans', function (table) { | ||
| table.dropColumn('params') | ||
| }) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| exports.up = function (knex, Promise) { | ||
| return knex.schema.createTableIfNotExists('orders', function (table) { | ||
| table.increments('id') | ||
| table.integer('agentId').references('agents.id') | ||
| }) | ||
| } | ||
|
|
||
| exports.down = function (knex, Promise) { | ||
| return knex.schema.dropTableIfExists('orders') | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| exports.up = function (knex, Promise) { | ||
| return knex.schema.table('taskPlans', function (table) { | ||
| table.dropColumn('assignee') | ||
| table.integer('assigneeId').references('assignee.id') | ||
| }) | ||
| } | ||
|
|
||
| exports.down = function (knex, Promise) { | ||
| return knex.schema.table('taskPlans', function (table) { | ||
| table.string('assignee').notNullable() | ||
| table.dropColumn('assigneeId') | ||
| }) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| import { combineEpics } from 'redux-observable' | ||
|
|
||
| import { epic as agents } from 'dogstack-agents' | ||
| import ordering from './ordering/epic' | ||
| import { epic as taskPlans } from './tasks/dux/plans' | ||
| import { epic as taskWorks } from './tasks/dux/works' | ||
| import { epic as orders } from './ordering/dux/orders' | ||
|
|
||
| export default combineEpics( | ||
| agents, | ||
| ordering, | ||
| orders, | ||
| taskPlans, | ||
| taskWorks | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import createModule from 'feathers-action' | ||
|
|
||
| const module = createModule('orders') | ||
|
|
||
| export const actions = module.actions | ||
| export const updater = module.updater | ||
| export const epic = module.epic |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gregorykan whats the thinking around proptypes? are we not going to use them at all?
and @ahdinosaur I am still curious and keen on an implementation of types on the apis of modules. Is the thinking that components shouldn't have a type api?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we've decided to not use them. but also still keen on a type api, just haven't made it a priority in our sprints to add type schemas, which maybe we should do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here's an issue for this meow: #118