-
Notifications
You must be signed in to change notification settings - Fork 1
feat: create credentials command #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sidharth-Singh10
wants to merge
9
commits into
rootCircle:main
Choose a base branch
from
Sidharth-Singh10:feat/create_creds
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: create credentials command #10
Sidharth-Singh10
wants to merge
9
commits into
rootCircle:main
from
Sidharth-Singh10:feat/create_creds
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Instead of a sub command we can create a automated rule, that does it when not exists! |
e1e614e to
74601c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created a
sub-commandto create new ssh credentials and direct users to add them to their github.In the flow discussed in the meet, the
create-credflow is supposed to run if all means of authentication fails, this can be achieved with the changes being introduced but I feel it would be better to inform the user to to runbgit create-credsinstead of running the command then and there (when auth fails) and forcing the user for an extra step.from my perspective, i think its better to keep the number of steps the user interacts with as minimal as possible.
Plus the auth could fail for plenty of other reasons the user may not be aware of or something user cannot fix.
Selecting existing key
Creating a new one