Skip to content

Conversation

@Sidharth-Singh10
Copy link
Contributor

created a sub-command to create new ssh credentials and direct users to add them to their github.

In the flow discussed in the meet, the create-cred flow is supposed to run if all means of authentication fails, this can be achieved with the changes being introduced but I feel it would be better to inform the user to to run bgit create-creds instead of running the command then and there (when auth fails) and forcing the user for an extra step.

from my perspective, i think its better to keep the number of steps the user interacts with as minimal as possible.
Plus the auth could fail for plenty of other reasons the user may not be aware of or something user cannot fix.

Selecting existing key

Screenshot_20250626_145041
Screenshot_20250626_145059
Screenshot_20250626_145125

Creating a new one

Screenshot_20250626_145157
Screenshot_20250626_145211
Screenshot_20250626_145238

@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

❌ Patch coverage is 0% with 563 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/auth/create/ssh.rs 0.00% 241 Missing ⚠️
src/auth/git_ssh.rs 0.00% 188 Missing ⚠️
src/auth/ssh_utils.rs 0.00% 60 Missing ⚠️
src/auth/git_http.rs 0.00% 40 Missing ⚠️
src/auth/git_auth.rs 0.00% 25 Missing ⚠️
src/cmd/create_creds.rs 0.00% 3 Missing ⚠️
src/events/git_clone.rs 0.00% 1 Missing ⚠️
src/events/git_pull.rs 0.00% 1 Missing ⚠️
src/events/git_push.rs 0.00% 1 Missing ⚠️
src/main.rs 0.00% 1 Missing ⚠️
... and 2 more
Files with missing lines Coverage Δ
src/cmd.rs 0.00% <ø> (ø)
src/events/git_clone.rs 0.00% <0.00%> (ø)
src/events/git_pull.rs 0.00% <0.00%> (ø)
src/events/git_push.rs 0.00% <0.00%> (ø)
src/main.rs 0.00% <0.00%> (ø)
src/workflows/default/prompt/pa07_ask_pull_push.rs 0.00% <0.00%> (ø)
src/workflows/default/prompt/pa13_pull_push.rs 0.00% <0.00%> (ø)
src/cmd/create_creds.rs 0.00% <0.00%> (ø)
src/auth/git_auth.rs 0.00% <0.00%> (ø)
src/auth/git_http.rs 0.00% <0.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rootCircle
Copy link
Owner

rootCircle commented Aug 12, 2025

Instead of a sub command we can create a automated rule, that does it when not exists!

@rootCircle rootCircle force-pushed the main branch 3 times, most recently from e1e614e to 74601c7 Compare August 16, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants