rootflo_llm as llm provider#163
Merged
Merged
Conversation
vishnurk6247
previously approved these changes
Nov 12, 2025
vizsatiz
requested changes
Nov 12, 2025
| yaml_str: str, | ||
| tools: Optional[List[Tool]] = None, | ||
| base_llm: Optional[BaseLLM] = None, | ||
| tool_registry: Optional[Dict[str, Tool]] = None, |
| base_url: The base URL of the proxy server | ||
| model_id: The model identifier | ||
| llm_provider: Type of LLM SDK to use (LLMProvider enum) | ||
| model_id: The model identifier (config_id) |
Member
There was a problem hiding this comment.
Can you add support for taking access_token directly, this will be useful when we do direct calls from authenticated users
Member
There was a problem hiding this comment.
Also throw exception at init, if there are missing stuff
| ) | ||
|
|
||
| # if access_token is not provided | ||
| if not access_token: |
Member
There was a problem hiding this comment.
Can you move this to a method and use it both here and in arium ?
| f'These can be provided via kwargs or environment variables (ROOTFLO_BASE_URL, ROOTFLO_APP_KEY, ROOTFLO_APP_SECRET, ROOTFLO_ISSUER, ROOTFLO_AUDIENCE).' | ||
| ) | ||
| else: | ||
| if not all([base_url, app_key]): |
| else: | ||
| raise ValueError(f'Unsupported model provider: {provider}') | ||
| if not model_name: | ||
| raise ValueError( |
Member
There was a problem hiding this comment.
Even the model choosing code can be made common
- using llm factory for llm instance creation in both arium and agent builder
vizsatiz
requested changes
Nov 18, 2025
| # Access token flow - only needs base_url and app_key | ||
| required_params = { | ||
| 'base_url': base_url, | ||
| 'app_key': app_key, |
vizsatiz
approved these changes
Nov 18, 2025
thomastomy5
pushed a commit
that referenced
this pull request
Apr 27, 2026
* rootflo_llm as llm provider * access_token option * utils -> llm factory - using llm factory for llm instance creation in both arium and agent builder * fix for failing tests * circular dependency fix for failing tests * ImageMessage -> ImageMessageContent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.