Skip to content

Update gopkg.in/yaml.v3 to v3.0.1#308

Closed
SaschaSchwarze0 wants to merge 1 commit into
rootless-containers:masterfrom
SaschaSchwarze0:sascha-update-yaml.v3
Closed

Update gopkg.in/yaml.v3 to v3.0.1#308
SaschaSchwarze0 wants to merge 1 commit into
rootless-containers:masterfrom
SaschaSchwarze0:sascha-update-yaml.v3

Conversation

@SaschaSchwarze0
Copy link
Copy Markdown

Based on go tool nm, the rootlesskit binary is not affected by CVE-2022-28948, but not every security scanning tool is smart enough to detect that.

@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-update-yaml.v3 branch from 3d9fb02 to 8bf889d Compare May 24, 2022 11:56
@AkihiroSuda AkihiroSuda added this to the v1.0.2 milestone May 25, 2022
@AkihiroSuda
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda removed this from the v1.0.2 milestone May 25, 2022
Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-update-yaml.v3 branch from 8bf889d to 4ef2c37 Compare May 31, 2022 06:57
@SaschaSchwarze0 SaschaSchwarze0 changed the title Update gopkg.in/yaml.v3 to v3.0.0 Update gopkg.in/yaml.v3 to v3.0.1 May 31, 2022
@SaschaSchwarze0
Copy link
Copy Markdown
Author

I think this should be fixed in the testify repo https://github.com/stretchr/testify/blob/285adcc5ced0bb267a7c874cfa3ca238266ce14f/go.mod#L9

Yeah, ideally. But that's a repo with >100 pull requests where things get rarely merged, at least three of the open PRs aim to fix it (stretchr/testify#1190, stretchr/testify#1192, stretchr/testify#1193). I leave it up to you.

In the meantime, I updated the PR to go to v3.0.1 based on go-yaml/yaml#666 (comment).

@AkihiroSuda
Copy link
Copy Markdown
Member

Thanks, but let me just remove testify

@AkihiroSuda AkihiroSuda closed this Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants