[Carry 362] support detach-netns#379
Merged
AkihiroSuda merged 2 commits intorootless-containers:masterfrom Jun 29, 2023
Merged
Conversation
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Closed
AkihiroSuda
force-pushed
the
carry-362
branch
2 times, most recently
from
799254a to
3e77937
Compare
Planned to be used for: - accelerating (and deflaking) `nerdctl pull` and `nerdctl build` - supporting `nerdctl run --net=host` This commit is based on PR 362 (originally authored by Fahed Dorgaa), but almost rewritten from scratch. Co-authored-by: fahed dorgaa <fahed.dorgaa@gmail.com> Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
fahedouch
reviewed
Jul 9, 2023
| return err | ||
| } | ||
| // this is hard (not impossible though) to reimplement in Go: https://github.com/cloudflare/slirpnetstack/commit/d7766a8a77f0093d3cb7a94bd0ccbe3f67d411ba | ||
| cmd := exec.Command("unshare", "-n", "mount", "--bind", "/proc/self/ns/net", p) |
Contributor
There was a problem hiding this comment.
agreed. It was hard to implement this in my previous PR too but the link example should help us ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Planned to be used for:
nerdctl pullandnerdctl buildnerdctl run --net=hostThis commit is based on PR #362 (originally authored by @fahedouch), but almost rewritten from scratch.