This repository was archived by the owner on Mar 9, 2026. It is now read-only.
refactor: inline src/issues into parse.ts and remove issues directory#68
Merged
refactor: inline src/issues into parse.ts and remove issues directory#68
Conversation
- Remove createIssue helper; inline issue object literals in parse.ts - Move FORBIDDEN_KEYS constant into parse.ts (internal use only) - Delete src/issues/ directory (forbiddenKeys.ts, forbiddenKeys.test.ts)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 1 -2
Lines 23 21 -2
Branches 5 5
=========================================
- Hits 23 21 -2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactoring to remove the
src/issues/directory and inline its contents intoparse.ts.createIssuehelper function and inline issue object literals at each call site inparse.tsFORBIDDEN_KEYSconstant (internal, unexported) intoparse.tssrc/issues/directory (forbiddenKeys.ts/forbiddenKeys.test.ts/createIssue.ts/createIssue.test.ts)Rationale
FORBIDDEN_KEYSis an internal constant not exported fromindex.ts; its only consumer isparse.tsforbiddenKeys.test.ts(checking that the set contains 3 values) is already covered behaviorally by theforbidden_keycases inparse.test.tsType of Change
Boundary Checklist
📘 AGENTS.md
Security & API Stability
parse,ParseResult,ParseIssue,IssueCode)Testing
bun run check:type:sourcepassesbun run testpassesbun run buildpasses🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com