This repository was archived by the owner on Mar 9, 2026. It is now read-only.
Conversation
…ces in boundary-validator Remove manually-maintained correct-pattern code blocks from references/ and replace with pointers to src/parse.ts and src/types/. Violation patterns, checklists, and grep commands are kept as they are unique to the skill and do not exist elsewhere. This eliminates the drift risk between reference docs and implementation without adding maintenance burden to contributors.
Relative hyperlinks caused 404 without branch/SHA context. Code spans (backticks) are sufficient for both AI agents and humans.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace manually-maintained correct-pattern code blocks in
skills/boundary-validator/references/with pointers to the source of truth.Problem
The reference files duplicated implementation code that was maintained separately from
src/. This caused drift — seen most recently in PR #70, whereSet<unknown>vsSet<string>, array vsReadonlySet, and stale versioning policy were all caused by the same root issue: two copies of the same truth.Adding a PR checklist or SKILL.md guidance would not reliably prevent this, as implementation PRs tend to focus on code rather than reference docs.
Change
Removed "correct pattern" code blocks from:
references/design-rules.mdreferences/security-rules.mdreferences/validation-patterns.mdreferences/api-contract.mdReplaced with:
See correct implementation: src/parse.ts/See source: src/types/Kept
.okprohibition (behavioral contract, not implementation detail)Type of Change
Boundary Checklist
📘 AGENTS.md
Security & API Stability
parse,ParseResult,ParseIssue,IssueCode)Testing
bun run check:type:sourcepassesbun run testpassesbun run buildpassesSignature
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com