Fix warning dynamic_reconfigure

[rbonghi]

Hi all,

I was working on my package when I approach this warning on my screen

[ WARN] [1586198292.260228386]: updateConfig() called on a dynamic_reconfigure::Server that provides its own mutex. This can lead to deadlocks if updateConfig() is called during an update. Providing a mutex to the constructor is highly recommended in this case. Please forward this message to the node author.

This pull-request fix the initialisation dynamic_reconfigure and now this warning is not show anymore.

PS: This pull-request should fix this answer https://answers.ros.org/question/310267/updateconfig-called-on-a-dynamic_reconfigureserver-that-provides-its-own-mutex/

[rbonghi]

I updated the mutex mDynServerMutex to dyn_reconf_server_mutex_ following @matthew-reynolds .

I removed the line

-    dyn_reconf_server_->getConfigDefault(config);

Should be fine now.

[matthew-reynolds]

Not sure what's up with Travis... I re-ran the build for the last commit (merge 5c3ff61 into melodic-devel) but it didn't update the status on GitHub, and now newest commit isn't being built either. @bmagyar thoughts?

Similar issue here: travis-ci/travis-ci#7643, but since the GitHub-Travis integration is still working properly on other PRs in this repo (#466), I don't think that's the issue.

[matthew-reynolds]

Looks good to me, just need to switch the boost::shared_ptr back to std::shared_ptr and a couple style nitpicks.

[rbonghi]

Hi @matthew-reynolds ,

I followed your hints and I updated all changes. In the first time #479 (comment) I thought was the same to use a boost and I didn't change it.

On travis is all green https://travis-ci.org/github/ros-controls/ros_controllers/builds/673500215 I do not why is in pending here.

[matthew-reynolds]

Yeah, Travis seems to be having some difficulty in the last few days.

Thanks for iterating, looks good to me.

[bmagyar]

I've squashed & rebased on the latest melodic-devel, going to merge when the CI is happy