Skip to content

Conversation

@k-okada
Copy link
Contributor

@k-okada k-okada commented Sep 17, 2014

  • setup helper program for generating calibration package for a robot
  • here is how I checked the program
    • run baxter simulaiton
<launch>
  <include file="$(find baxter_gazebo)/launch/baxter_world.launch" />
  <anode pkg="baxter_interface" type="joint_trajectory_action_server.py"
        args="--limb both" name="joint_trajectory_action_server" />
  <node pkg="image_proc" type="image_proc" name="camera_rgb_image_proc"
        ns="/camera/rgb" />
  <node pkg="topic_tools" type="relay" args="/robot/joint_states /joint_states"
        name="joint_states_relay" />
  <node pkg="image_view" type="image_view" name="image_view_rect" >
    <remap from="image" to="/camera/rgb/image_rect" />
  </node>

</launch>
  • run setup helper under <catkin_ws>/src/ directory
(cd src; rosrun calibration_setup_helper calibration_setup_helper.py
        `rospack find baxter_description`/urdf/baxter.urdf
        --base-link 'torso' --arm-end-link 'right_gripper_base'
        --head-end-link 'camera_rgb_frame'
        --arm-controller=/robot/limb/right/command
        --head-controller=/robot/limb/head/command)
  • run catkin_make to register generated baxter_calibration package
  • run make_sample.py program to correct calib posture
rosrun baxter_calibration make_samples.py

use C-c to step

  • run capture data program
roslaunch baxter_calibration capture_data.launch
  • run calibration program
rosrun baxter_calibration calibrate_baxter.sh

@k-okada
Copy link
Contributor Author

k-okada commented Sep 17, 2014

@k-okada k-okada force-pushed the add_calibration_setup_helper branch 2 times, most recently from 9a4f0e2 to eb1dac8 Compare September 19, 2014 10:40
@k-okada
Copy link
Contributor Author

k-okada commented Sep 20, 2014

It may not work well, please do not merge yet

@k-okada k-okada force-pushed the add_calibration_setup_helper branch 2 times, most recently from e467b61 to f93eac6 Compare September 23, 2014 13:22
@k-okada k-okada force-pushed the add_calibration_setup_helper branch from f93eac6 to 2fcb6f7 Compare September 24, 2014 09:53
@k-okada
Copy link
Contributor Author

k-okada commented Sep 24, 2014

I think it is now ok to merge

@garaemon
Copy link
Contributor

+1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please @k-okada , set yourself as an author and maintainer.

@vrabaud
Copy link
Contributor

vrabaud commented Nov 16, 2014

also, please add a REAMD file that contains what you described at the beginning of that bug report.
@mikeferguson , any opinion against ? Looks pretty useful to me

@mikeferguson
Copy link
Member

I didn't look at it in detail, but it seems fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a license (may I recommend Apache 2.0 like anything OSRF does), you can copy paste from here:https://github.com/ros-aldebaran/romeo_robot/blob/master/romeo_description/scripts/generate_urdf.py

@vrabaud
Copy link
Contributor

vrabaud commented Dec 14, 2014

please set yourself as an author/maintainer. Installing your script would be more proper with a setup.py (especially to make your code runnable from Python3)

@k-okada k-okada mentioned this pull request Dec 15, 2014
@k-okada
Copy link
Contributor Author

k-okada commented Dec 15, 2014

ok, I have fexed, and also create #37 that include branch to use setup.py. Just to make sure that if se use setup.py , it install the script under global bin instead of package bin. Is it ok?

@vrabaud
Copy link
Contributor

vrabaud commented Dec 15, 2014

You are totally right, this is not ok :( I was wrong.
The setup.py helps dealing with Python 3 but let's ignore that for now. Just update the maintainers/authors and license on this pull request.
Sorry for the noise.

vrabaud added a commit that referenced this pull request Dec 21, 2014
@vrabaud vrabaud merged commit 578a789 into ros-perception:hydro Dec 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants