This repository was archived by the owner on May 31, 2025. It is now read-only.
Port actionlib_tools to Python 3#169
Merged
mjcarroll merged 4 commits intoros:noetic-develfrom Aug 21, 2020
Merged
Conversation
reinzor
approved these changes
Aug 17, 2020
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
mikaelarguedas
force-pushed
the
port_actionlib_tools_to_python3
branch
from
28a1804 to
5a11f58
Compare
mjcarroll
approved these changes
Aug 21, 2020
Member
mjcarroll
left a comment
mjcarroll
left a comment
There was a problem hiding this comment.
LGTM, one comment on shebang consistency
Co-authored-by: Michael Carroll <michael@openrobotics.org>
Merged
mjcarroll
approved these changes
Aug 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #168 and ros/rosdistro#25920
Should fix #153 and #167