Skip to content

Use new version of gtest to fix windows warnings #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
scpeters merged 2 commits into from
Jan 29, 2018
Merged

Use new version of gtest to fix windows warnings #54

scpeters merged 2 commits into from
Jan 29, 2018

Conversation

@scpeters
Copy link
Contributor

@scpeters scpeters commented Jan 29, 2018

Closes #51

@scpeters scpeters mentioned this pull request Jan 29, 2018
Closed
@dirk-thomas
Copy link
Member

dirk-thomas commented Jan 29, 2018

Thank you for creating the patch. http://ci.ros2.org/job/ci_windows/4006/ looks good to me - the console_bridge related warnings are gone.

@scpeters scpeters merged commit ad25f73 into ros:master Jan 29, 2018
@scpeters scpeters deleted the gtest_new branch January 29, 2018 20:13
@scpeters scpeters mentioned this pull request Mar 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scpeters @dirk-thomas