Skip to content

Conversation

@Blast545
Copy link
Contributor

@Blast545 Blast545 commented Jun 4, 2020

As the title says, missing information is added to the QD of the package.

Signed-off-by: Jorge Perez jjperez@ekumenlabs.com

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@Blast545
Copy link
Contributor Author

Blast545 commented Jun 4, 2020

PTAL @brawner @chapulina

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2020

Codecov Report

Merging #83 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   65.00%   65.00%           
=======================================
  Files           2        2           
  Lines          60       60           
=======================================
  Hits           39       39           
  Misses         21       21           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 542ac0a...01fb5de. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the updates look good to me. Next-up, quality level 1! 🚀

Copy link
Contributor

@brawner brawner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the minor typos and it looks good to me!

Current test results are shown here:

[Linux (Travis CI)](https://travis-ci.org/github/ros/console_bridge)
[Windows (Appveyor)](https://ci.appveyor.com/project/tfoote/console-bridge)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not possible to get Appveyor under ROS or the console_bridge name?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how appveyor works exactly. I believe I didn't have sufficient permissions to enable appveyor for this repo, so @tfoote did it for me.

It's way overkill, but if we switched to GitHub actions, I think that would get rid of tfoote's name in the URL. 😅

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@scpeters scpeters merged commit 7a64d37 into ros:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants