This repository was archived by the owner on May 31, 2025. It is now read-only.
Merged
Conversation
Member
|
@ros-pull-request-builder retest this please |
tfoote
approved these changes
Aug 17, 2018
Member
tfoote
left a comment
tfoote
left a comment
There was a problem hiding this comment.
The change looks good to me. Just going to rerun the unit tests.
Contributor
|
@tfoote the tests have passed, could this possibly be merged? |
seanyen
pushed a commit
to ms-iot/geometry2
that referenced
this pull request
Mar 22, 2021
…rmBroadcaster. (ros#320) * handle None for qos argument
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds compatibility for python3.7. The return type of PyUnicode_AsUTF8AndSize has changed to
const char *as opposed tochar *. This change should be compatible with previous versions of python as well.