Skip to content
This repository was archived by the owner on Aug 3, 2020. It is now read-only.

Conversation

@bmagyar
Copy link
Contributor

@bmagyar bmagyar commented Sep 3, 2016

This adds the common typedefs that already exist for the rest of the classes in the urdf namespace.

@jspricke
Copy link
Member

I would propose to use std::shared_ptr here, as urdf::Model inherits from urdf::ModelInterface and urdfdom_headers switched to std::shared_ptr already.

@bmagyar
Copy link
Contributor Author

bmagyar commented Sep 11, 2016

Hiya,
I am fully aware of that. Moving to these macros consistently in
ros_control is what I've been working on recently in order to ease
"unboosting" when it happens. The stuff in the urdf headers haven't been
released yet, this brings the local urdf class up to date w the released
version of that.

On 11 Sep 2016 11:53, "Jochen Sprickerhof" notifications@github.com wrote:

I would propose to use std::shared_ptr here, as urdf::Model inherits from
urdf::ModelInterface and urdfdom_headers switched to std::shared_ptr
already.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#153 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADXH4c7Yz0lmq3ziGOVOZgRRPe4vjaAsks5qo92agaJpZM4J0aMq
.

@de-vri-es
Copy link
Contributor

de-vri-es commented Sep 24, 2016

This PR would be very welcome. MoveIt is currently being migrated to std smart pointers, so any remaining explicit boost::shared_ptr is an eyesore.

More importantly, once urdf switches to std::shared_ptr, explicit usage of boost::shared_ptr will stop compiling. It would be nice to be able to prepare for that by using these typedefs before the actual switch is done.

@bmagyar
Copy link
Contributor Author

bmagyar commented Sep 25, 2016

@wjwwood ?

@wjwwood wjwwood merged commit f8cb99c into ros:kinetic-devel Sep 28, 2016
@de-vri-es de-vri-es mentioned this pull request Oct 2, 2016
@davetcoleman
Copy link
Contributor

When will these pointers be switched to std? Currently in Lunar all of the shared_ptrs in urdfdom/urdfdom_headers uses std, but this one Model class still uses boost.

v4hn added a commit to v4hn/robot_model that referenced this pull request Jul 18, 2017
In the kinetic-devel branch ros#153 introduced typedefs
for the `Model` class of this package.
Later, ros#206 moved these typedefs over to the
`urdfdom_compatibility.h` header.

The main purpose of the header is to ease compatibility between indigo
and kinetic+, so these typedefs should also be provided in indigo-devel.
v4hn added a commit to v4hn/robot_model that referenced this pull request Jul 18, 2017
In the kinetic-devel branch ros#153 introduced typedefs
for the `Model` class of this package.
Later, ros#206 moved these typedefs over to the
`urdfdom_compatibility.h` header.

The main purpose of the header is to ease compatibility between indigo
and kinetic+, so these typedefs should also be provided in indigo-devel.
clalancette pushed a commit that referenced this pull request Jul 27, 2017
In the kinetic-devel branch #153 introduced typedefs
for the `Model` class of this package.
Later, #206 moved these typedefs over to the
`urdfdom_compatibility.h` header.

The main purpose of the header is to ease compatibility between indigo
and kinetic+, so these typedefs should also be provided in indigo-devel.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants