This repository was archived by the owner on May 31, 2025. It is now read-only.
Adds and updates urdf ecosystem diagram #33
Merged
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Migrates urdf_diagram.odg and urdf_diagram.png from robot_model pkg to this urdf pkg - Updates urdf_diagram for current repo structures and urls - Adds rendering from diagram in README.md
Contributor
Author
|
@clalancette here are the updates based on our discussion yesterday |
clalancette
approved these changes
May 8, 2020
Collaborator
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
This looks good to me, thanks for the update @IanTheEngineer
Collaborator
|
@sloretz Any objection to merging these binary data files into this git repository? |
sloretz
approved these changes
May 8, 2020
Contributor
Author
|
@clalancette & @sloretz - I can't upload the new diagram to the ROS wiki (an admin is needed for image upload privileges i think?). Who should we ping to add the PR'd image to http://wiki.ros.org/urdf ? |
Collaborator
I've uploaded it now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates urdf_diagram.odg and urdf_diagram.png from robot_model pkg
to this urdf pkg
Updates urdf_diagram for current repo structures and urls
Adds rendering from diagram in README.md