Skip to content

Conversation

@nickswalker
Copy link
Contributor

Makes it easier to pipe results from xacro, and matches urdfdom_py's behavior
Switch an fstream to an ifstream for clarity
Closes #170

Makes it easier to pipe results from xacro, and matches urdfdom_py's behavior
Closes #170
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. This looks good, I'll run CI on it just to be sure.

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 6d3c5de into ros:master Aug 28, 2023
harleylara pushed a commit to traversaro/urdfdom that referenced this pull request Feb 15, 2024
Makes it easier to pipe results from xacro, and matches urdfdom_py's behavior
Closes ros#170

Signed-off-by: harleylara <harley.lara@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: check_urdf should be able to read from std_in

3 participants