Read cmake version from package.xml #236
Merged
+10
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use regex to match version string. Based on suggestion from Chris Lalancette. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This was referenced Dec 16, 2025
clalancette
reviewed
Dec 16, 2025
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
I've left one minor thing that we should consider fixing, otherwise this looks good to me.
Co-authored-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
force-pushed
the
scpeters/cmake_version_from_package_xml_no_python
branch
from
d73d82d to
3c14334
Compare
clalancette
approved these changes
Dec 17, 2025
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
This looks good to me! Thanks for taking this one @scpeters
scpeters
deleted the
scpeters/cmake_version_from_package_xml_no_python
branch
scpeters
added a commit
to ros/urdfdom_headers
that referenced
this pull request
Dec 17, 2025
Use regex to match version string. Copied from ros/urdfdom#236. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This was referenced Dec 17, 2025
ahcorde
pushed a commit
to ros/urdfdom_headers
that referenced
this pull request
Dec 18, 2025
Use regex to match version string. Copied from ros/urdfdom#236. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the package version is set in both package.xml and the CMakeLists.txt file and it's easy for them to get out of sync. This updates the cmake code to extract the version string from the package.xml file using a regular expression and passing it to the cmake
project()call. This approach implements the suggestion by @clalancette in #233 (review).Alternative to #233 and #232.
cc @saikishor, @traversaro