Scoped macro evaluation [Noetic]#272
Merged
Merged
Conversation
... to be used for both, symbols and macros. To this end, remove global_symbols from Table's source code and instead, store this dict as its root. If no root parent is passed, an empty dict is used, which simplifies lookup.
This was referenced Mar 31, 2021
Closed
Doomerdinger
approved these changes
May 3, 2021
Contributor
Doomerdinger
left a comment
Doomerdinger
left a comment
There was a problem hiding this comment.
I am not incredibly farmiliar with the inner workings of xacro, but this all looks ok.
Fixed the issues I was seeing with scoping - but I was only able to test on Melodic.
rhaschke
added a commit
that referenced
this pull request
Jan 20, 2022
… from Table This is another fixup of #272, which introduced macros to be an instance of Table. However, this also requires namespaced macro dicts to be Table instances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #270.