Skip to content

Conversation

@jacobperron
Copy link
Contributor

This package is required by rcljava_examples.

Also, append .git to repository URLs for consistency

This package is required by rcljava_examples.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Copy link
Contributor

@nielstiben nielstiben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified that with Jacob's changes, the source code for dashing is able to build.

@jacobperron jacobperron requested a review from esteve May 6, 2020 15:53
Copy link
Member

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobperron thanks!

@esteve esteve merged commit 2810b42 into dashing May 6, 2020
@jacobperron jacobperron deleted the add_example_interfaces branch May 6, 2020 16:07
jacobperron added a commit that referenced this pull request May 17, 2021
* Add example_interfaces to desktop repos file

This package is required by rcljava_examples.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Append .git to repository URLs for consistency

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron added a commit that referenced this pull request May 17, 2021
* Add example_interfaces to desktop repos file

This package is required by rcljava_examples.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Append .git to repository URLs for consistency

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants