Skip to content

Conversation

@nielstiben
Copy link
Contributor

Updated README.md to show the corresponding 'dashing' branch in the instructions instead of the 'master' branch.

@nielstiben nielstiben changed the base branch from master to dashing May 6, 2020 12:27
@esteve esteve self-requested a review May 6, 2020 16:45
@esteve
Copy link
Member

esteve commented May 6, 2020

@nielstiben thanks! Just some really minor feedback, given that you're updating the URLs with the branch name, I thought it'd be nice to also update the organization part.

Changed the repository links from a private github account to ROS2 Organisation repositories links.
@nielstiben
Copy link
Contributor Author

@esteve Thank you for the feedback! have processed the requested changes.

@nielstiben nielstiben requested a review from esteve May 6, 2020 17:59
Copy link
Member

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nielstiben thanks! :-)

@esteve esteve merged commit 6516da0 into ros2-java:dashing May 7, 2020
jacobperron pushed a commit that referenced this pull request May 17, 2021
* Fix README with correct branch in the instructions.

* Update README instructions repository links.

Changed the repository links from a private github account to ROS2 Organisation repositories links.

Co-authored-by: Niels Tiben <nielstiben@outlook.com>
jacobperron pushed a commit that referenced this pull request May 17, 2021
* Fix README with correct branch in the instructions.

* Update README instructions repository links.

Changed the repository links from a private github account to ROS2 Organisation repositories links.

Co-authored-by: Niels Tiben <nielstiben@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants