(RclJava) fix BaseExecutor.spinSome logic - run the executable even i… #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esteve
reviewed
Sep 17, 2020
Member
esteve
left a comment
esteve
left a comment
There was a problem hiding this comment.
Correct me if I'm wrong, but these two look equivalent. Could you show an example where the execution differs? Thanks.
Contributor
|
@esteve The problem is on L332. If the executable is not null, then we're skipping it. |
Member
|
@sung-goo-kim @jacobperron thanks, I didn't catch that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, executable did not run if getNextExecutable() is not null.