Compile generated action-related services #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The request and response messages are already generated as part of the srv template. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
The generated C headers for actions are included in a single header named after the action. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Though not strictly necessary, it is nice to have definitions for these action-specific services for the purpose of writing unit tests. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Previously, though we were generated service definitions for actions we were not compiling them. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This was referenced Oct 20, 2020
Open
ivanpauno
approved these changes
Oct 20, 2020
Contributor
ivanpauno
left a comment
ivanpauno
left a comment
There was a problem hiding this comment.
I haven't really tested this, but the changes look good to me!
jacobperron
added a commit
to osrf/ros2_java
that referenced
this pull request
Nov 9, 2020
* Remove redundant code generation The request and response messages are already generated as part of the srv template. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Strip action service suffixes from C include prefix The generated C headers for actions are included in a single header named after the action. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Generate Java code for SendGoal and GetResult service definitions Though not strictly necessary, it is nice to have definitions for these action-specific services for the purpose of writing unit tests. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Compile generated service definitions for actions Previously, though we were generated service definitions for actions we were not compiling them. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
to osrf/ros2_java
that referenced
this pull request
Nov 10, 2020
* Remove redundant code generation The request and response messages are already generated as part of the srv template. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Strip action service suffixes from C include prefix The generated C headers for actions are included in a single header named after the action. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Generate Java code for SendGoal and GetResult service definitions Though not strictly necessary, it is nice to have definitions for these action-specific services for the purpose of writing unit tests. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Compile generated service definitions for actions Previously, though we were generated service definitions for actions we were not compiling them. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
to osrf/ros2_java
that referenced
this pull request
Nov 10, 2020
* Remove redundant code generation The request and response messages are already generated as part of the srv template. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Strip action service suffixes from C include prefix The generated C headers for actions are included in a single header named after the action. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Generate Java code for SendGoal and GetResult service definitions Though not strictly necessary, it is nice to have definitions for these action-specific services for the purpose of writing unit tests. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Compile generated service definitions for actions Previously, though we were generated service definitions for actions we were not compiling them. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
to osrf/ros2_java
that referenced
this pull request
Nov 10, 2020
* Remove redundant code generation The request and response messages are already generated as part of the srv template. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Strip action service suffixes from C include prefix The generated C headers for actions are included in a single header named after the action. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Generate Java code for SendGoal and GetResult service definitions Though not strictly necessary, it is nice to have definitions for these action-specific services for the purpose of writing unit tests. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Compile generated service definitions for actions Previously, though we were generated service definitions for actions we were not compiling them. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
to osrf/ros2_java
that referenced
this pull request
Nov 10, 2020
* Remove redundant code generation The request and response messages are already generated as part of the srv template. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Strip action service suffixes from C include prefix The generated C headers for actions are included in a single header named after the action. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Generate Java code for SendGoal and GetResult service definitions Though not strictly necessary, it is nice to have definitions for these action-specific services for the purpose of writing unit tests. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Compile generated service definitions for actions Previously, though we were generated service definitions for actions we were not compiling them. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
to osrf/ros2_java
that referenced
this pull request
Nov 10, 2020
* Remove redundant code generation The request and response messages are already generated as part of the srv template. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Strip action service suffixes from C include prefix The generated C headers for actions are included in a single header named after the action. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Generate Java code for SendGoal and GetResult service definitions Though not strictly necessary, it is nice to have definitions for these action-specific services for the purpose of writing unit tests. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Compile generated service definitions for actions Previously, though we were generated service definitions for actions we were not compiling them. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
May 17, 2021
* Remove redundant code generation The request and response messages are already generated as part of the srv template. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Strip action service suffixes from C include prefix The generated C headers for actions are included in a single header named after the action. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Generate Java code for SendGoal and GetResult service definitions Though not strictly necessary, it is nice to have definitions for these action-specific services for the purpose of writing unit tests. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Compile generated service definitions for actions Previously, though we were generated service definitions for actions we were not compiling them. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though service generation was fixed in #76, the new files were not added to the CMakeLists.txt for compilation. This PR contains the following: