Avoid unnecessary string copies #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanpauno
approved these changes
Jan 8, 2021
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
force-pushed
the
jacob/avoid_string_copies
branch
from
58d0684 to
b635e8a
Compare
Contributor
Author
|
I've rebased to try and resolve CI errors. |
jacobperron
added a commit
that referenced
this pull request
May 17, 2021
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use the C strings returned
GetStringUTFCharsdirectly, instead of copying to an intermediatestd::string.