update repro for dashing #80
Conversation
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
There's a few things that should be fixed here.
Honestly, we should just remove this file, and instead have a much smaller version which just adds the additional repositories needed on top of dashing.
ros2_java_android.repos
Outdated
| type: git | ||
| url: https://github.com/eProsima/Fast-CDR.git | ||
| version: v1.0.7 | ||
| version: release/1.0.10 |
There was a problem hiding this comment.
Looking at https://github.com/ros2/ros2/blob/dashing/ros2.repos , this should be the v1.0.11 tag.
ros2_java_android.repos
Outdated
| type: git | ||
| url: https://github.com/eProsima/Fast-RTPS.git | ||
| version: 7a0b0fe7ca8d2c4ea41e36744c6024c263a6505a | ||
| version: release/1.8.0 |
There was a problem hiding this comment.
Looking at https://github.com/ros2/ros2/blob/dashing/ros2.repos , this should be the v1.8.2 tag.
ros2_java_android.repos
Outdated
| url: https://github.com/esteve/ros2_java.git | ||
| version: master | ||
| url: https://github.com/ros2-java/ros2_java | ||
| version: rcljava_dashing |
There was a problem hiding this comment.
This should just be dashing.
|
@clalancette can't be done because all of these repositories need to be crosscompiled for Android, the prebuilt ROS 2 distros can't be used. |
Change https://github.com/eProsima/Fast-CDR.git to release/1.0.11 tag
|
@esteve Can you approve my changes? |
|
FWIW, here's a related PR for the desktop repos file (in which we don't need to build all ROS 2 packages from source): #94 |
ros2_java_android.repos
Outdated
| type: git | ||
| url: https://github.com/eProsima/Fast-CDR.git | ||
| version: v1.0.7 | ||
| version: release/1.0.11 |
There was a problem hiding this comment.
I think this should be v1.0.11 (matching the version used in Dashing).
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
4 participants
No description provided.