Fix tf2_ros test errors across all platforms#171
Merged
clalancette merged 5 commits intoros2:ros2from Sep 17, 2019
Merged
Conversation
Signed-off-by: evshary <evshary@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Contributor
|
Thanks for the fix. It looks like I had a typo when running CI on #99 code yesterday, so all of the tests didn't run. I've added a couple more fixes here, and I'll now run CI to see if this fixes most of the problems: Linux |
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Contributor
|
Linux is fixed with the changes here. There is one more error coming from Windows Debug that I'm working on. |
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Since it is a virtual class, we want to make sure that the destructor is virtual. This fixes a warning from clang. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Contributor
|
Here's a CI on everything except for Windows Debug (I may end up addressing that in a separate PR, since I want to get these changes in for everything else):
|
clalancette
changed the title
tfoote
approved these changes
Sep 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running CI test, there are some error messages like this
I think the root cause is the wrong path of class Clock. It should be
rclpy.clock.Clock().