Skip to content

Enable intra-process (#649) #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahcorde merged 3 commits into from
Jan 31, 2024
Merged

Enable intra-process (#649) #642

ahcorde merged 3 commits into from
Jan 31, 2024

Conversation

@roncapat
Copy link
Contributor

@roncapat roncapat commented Jan 22, 2024 •
edited
Loading

Closes #629.

  • Revert previously added patches
  • Pass tests in CI

Note to maintainers: please do not backport.

@roncapat roncapat marked this pull request as ready for review January 22, 2024 10:07
@roncapat
Copy link
Contributor Author

roncapat commented Jan 22, 2024

@jefferyyjhsu now that ros2/rclcpp#2303 got merged, may I ask you what is wrong with CI failing here now? I get:

C++ exception with description "intraprocess communication allowed only with volatile durability" thrown in the test body.

but in your (now merged) PR those messages got removed.

CC @clalancette

@roncapat
Copy link
Contributor Author

roncapat commented Jan 22, 2024

It seems to me that in Jenkins log it is mentioned:
ros-rolling-rclcpp: 25.0.0-1jammy.20231227.152603 so maybe it's just a sync issue.

@roncapat roncapat changed the title Enalbe intra-process (#649) Enable intra-process (#649) Jan 22, 2024
@clalancette
Copy link
Contributor

clalancette commented Jan 22, 2024

ros-rolling-rclcpp: 25.0.0-1jammy.20231227.152603 so maybe it's just a sync issue.

Yeah, we haven't done a new release with those changes, so the Rpr job won't pick it up yet. That's OK, we have completely from-source CI available, once this PR is approved that will be run.

@jefferyyjhsu
Copy link

jefferyyjhsu commented Jan 22, 2024

ros-rolling-rclcpp: 25.0.0-1jammy.20231227.152603 so maybe it's just a sync issue.

Yeah, we haven't done a new release with those changes, so the Rpr job won't pick it up yet. That's OK, we have completely from-source CI available, once this PR is approved that will be run.

@roncapat and @clalancette, let me know if the issue persists in from-source CI tests.

tfoote
tfoote approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great to be able to restore the intra process comms for tf.

@tfoote
Copy link
Contributor

tfoote commented Jan 31, 2024

CI full build with this fork overridden

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor

ahcorde commented Jan 31, 2024

@ros-pull-request-builder retest this

@ahcorde ahcorde merged commit bfc9a8b into ros2:rolling Jan 31, 2024
jplapp pushed a commit to pixel-robotics/geometry2 that referenced this pull request Feb 19, 2024
@roncapat @jplapp
Enable intra-process (ros2#649) (ros2#642)
b038972
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tfoote tfoote tfoote approved these changes

@ahcorde ahcorde Awaiting requested review from ahcorde

@clalancette clalancette Awaiting requested review from clalancette

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support intra-process comm

5 participants

@roncapat @clalancette @jefferyyjhsu @tfoote @ahcorde