[humble] Optimize "already present" check for TimeCache::insertData()#677
Closed
EricCousineau-TRI wants to merge 1 commit intoros2:humblefrom
Closed
[humble] Optimize "already present" check for TimeCache::insertData()#677EricCousineau-TRI wants to merge 1 commit intoros2:humblefrom
EricCousineau-TRI wants to merge 1 commit intoros2:humblefrom
Conversation
Contributor
|
Let's hold off on this until we fix up |
Contributor
Author
|
sgtm. Closing in lieu of #680 and other discussions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #676 on
humbleI attempted to rebase onto
rolling(as of 24643fc), but there are changes that seem like they need to be optimized too