[cache_unittest] Add direct implementation testing on ordering, pruning (backport #678)#689
Merged
[cache_unittest] Add direct implementation testing on ordering, pruning (backport #678)#689
Conversation
…ng (#678) * [cache_unittest] Add direct implementation testing on ordering, pruning * do getAllItems() approach * Return a reference instead. * mark getAllItems as internal * Fix warning on Windows. Co-authored-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit a17a2bf) # Conflicts: # tf2/include/tf2/time_cache.h
Contributor
Author
|
Cherry-pick of a17a2bf has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Contributor
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #676
This changes nothing pertaining to the implementation. It only adds testing.
Some of it is implementation-specific, but towards the ends of performance checks.
From #676 (comment)
To answer them:
ImplSortedDescendingUniqueEntriesImplSortedDescendingUniqueEntriesImplSortedDescendingUniqueEntriesImplSortedDescendingUniqueEntriesThis is an automatic backport of pull request [cache_unittest] Add direct implementation testing on ordering, pruning #678 done by Mergify.