Skip launch tests entirely on Windows. #374
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Member
|
I am ok with merging this as a temporary workaround. But I want someone to be fully focused on resolving this issue and reenabling these tests asap. |
Contributor
Author
|
I agree, and I plan to work on figuring out what's going on this week (partially focused though). This is far (very far) from ideal, but I wanted the buildcop to have another option. |
Member
|
Considering the recent merge of ros2/ros2cli#489, I will close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somewhat excessively harsh, but an easy option to get the job queue unstuck.
CI on usually hanging ros2cli packages: