Topic correct typeadapter deduction (backport #2294) #2297
Merged
+45
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix TypeAdapter deduction Signed-off-by: Chen Lihui <lihui.chen@sony.com> (cherry picked from commit 5e152d7)
alsora
approved these changes
Sep 6, 2023
fujitatomoya
approved these changes
Sep 6, 2023
Collaborator
|
@iuhilnehc-ynos i think we would want to give it some soak time for this like a week to make sure nothing happens to rolling. and then we can start the CI to merge. (the same goes to #2298) |
Collaborator
|
CI:
|
Collaborator
|
CI(retry):
|
|
It would be nice to also backport #2292 as this PR breaks C++20 compatibility for humble. Is there any plan related this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2294 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com