NEW PR: Add component_container for EventsExecutor #2885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihir Rao <mihirr@nvidia.com>
Contributor
Author
|
@fujitatomoya Created a new and clean PR for this. |
Signed-off-by: Mihir Rao <mihirr@nvidia.com>
fujitatomoya
approved these changes
Jun 26, 2025
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm, i would like to have 2nd review for this.
CC: @alsora
Note
EventsExecutor is not explained in official documentation yet and still maintained under experimental namespace. We can follow up the component_container_event documentation once EventsExecutor is promoted to official Executor.
alsora
approved these changes
Jun 28, 2025
Collaborator
|
CI
|
Collaborator
|
CI failures are unrelated to this PR. thanks for the contribution. |
|
This pull request has been mentioned on Open Robotics Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-performance-benchmarking/44382/5 |
|
Hi! Do you plan to backport this to jazzy? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a component container for the events executor.
Is this user-facing behavior change?
No
Did you use Generative AI?
Yes
PR created by
mihirr-NVCode changes created with help from Cursor + gemini-2.5-pro.
Additional Information
N/A